Skip to content

DATAREDIS-1143 - Delombok source files. #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

No description provided.

mp911de pushed a commit that referenced this pull request May 14, 2020
mp911de added a commit that referenced this pull request May 14, 2020
Replace delomboked equals/hashCode with Spring-style equals/hashCode.

Original pull request: #530.
@mp911de
Copy link
Member

mp911de commented May 14, 2020

That's merged and polished now.

@mp911de mp911de closed this May 14, 2020
@mp911de mp911de deleted the issue/DATAREDIS-1143 branch May 14, 2020 09:59
@quaff
Copy link
Contributor

quaff commented Aug 11, 2020

@mp911de Would you explain why?

@mp911de
Copy link
Member

mp911de commented Aug 11, 2020

Lombok introduces some side-effects when starting out to use it, such as the class files get changed with the annotation processor while the source code itself (which goes into -sources.jar) remains unchanged. Similar goes for Javadoc: While lombok generates methods and such, those don't show up in the Javadoc. One needs to heavily customize a project setup to bring in back those things. So Lombok caused more issues in production code than good.

@quaff
Copy link
Contributor

quaff commented Aug 11, 2020

Does those issues can be fixed in lombok or it's impossible by annotation processor?

@quaff
Copy link
Contributor

quaff commented Aug 11, 2020

Class files get changed even source files remains changed is trivial since we are not add those generated files to VCS.
does this occurs even lombok self not upgraded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants